Skip to content

Remove full stop from bytes syntaxerror message#24300

Merged
pablogsal merged 1 commit into
python:masterfrom
numbermaniac:patch-1
Jan 23, 2021
Merged

Remove full stop from bytes syntaxerror message#24300
pablogsal merged 1 commit into
python:masterfrom
numbermaniac:patch-1

Conversation

@numbermaniac

@numbermaniac numbermaniac commented Jan 23, 2021

Copy link
Copy Markdown
Contributor

Every other error I've seen raised by Python doesn't have a full stop at the end. This one appears to be an anomaly, so this PR removes the full stop to make it consistent with other errors.

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 23, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@numbermaniac

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@numbermaniac

numbermaniac commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

The "requested review" was automatic, I didn't do it myself. I hope I haven't accidentally bothered anyone unnecessarily with that!

@pablogsal

pablogsal commented Jan 23, 2021

Copy link
Copy Markdown
Member

Thanks for the catch @numbermaniac !

@pablogsal pablogsal merged commit bf9239b into python:master Jan 23, 2021
@numbermaniac numbermaniac deleted the patch-1 branch January 24, 2021 01:03
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@numbermaniac @adorilson
Remove full stop from a bytes-related SyntaxError message (pythonGH-2…
f063d48 
…4300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@numbermaniac @the-knights-who-say-ni @pablogsal @bedevere-bot