Skip to content

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper #24170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 5 commits into from
Jan 9, 2021
Merged

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper #24170

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70f8bca
bpo-24464: Call sqlite3.enable_shared_cache() from deprecation wrapper
Jan 8, 2021
260bbf3
Fix test_shared_cache_deprecated on macOS
Jan 8, 2021
2eb92b6
Address review
Jan 9, 2021
aecdd28
Removed one line too many
Jan 9, 2021
83f1b74
Update dbapi.py
berkerpeksag Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_shared_cache_deprecated on macOS
  • Loading branch information
Erlend E. Aasland committed Jan 8, 2021
commit 260bbf3c7d6029b0448d948672f99350171a4d7a
7 changes: 6 additions & 1 deletion Lib/sqlite3/test/dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ def test_not_supported_error(self):
def test_shared_cache_deprecated(self):
for enable in (True, False):
with self.assertWarns(DeprecationWarning) as cm:
sqlite.enable_shared_cache(enable)
try:
sqlite.enable_shared_cache(enable)
except sqlite.OperationalError as err:
# See issue 24464 and https://sqlite.org/c3ref/enable_shared_cache.html
import sys
self.assertEqual(sys.platform, 'darwin')
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
self.assertIn("dbapi.py", cm.filename)


Expand Down