Skip to content

bpo-35134: Add Include/cpython/pytime.h file #23988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Feb 16, 2021
Merged

bpo-35134: Add Include/cpython/pytime.h file #23988

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7f2d83
bpo-35134: Add Include/cpython/pytime.h file
nw0 Dec 24, 2020
c6233c6
remove Include/pytime.h
nw0 Feb 13, 2021
aa97ca2
remove bad pyconfig include
nw0 Feb 13, 2021
1c0f8ad
restore some accidentally-deleted whitespace
nw0 Feb 13, 2021
3116f44
pytime.h: remove includes
nw0 Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove bad pyconfig include
  • Loading branch information
@nw0
nw0 committed Feb 13, 2021
commit aa97ca2d05b4b00598eee42f3313e6c4254835ee
1 change: 0 additions & 1 deletion Include/cpython/pytime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#ifndef Py_PYTIME_H
#define Py_PYTIME_H

#include "../pyconfig.h" /* include for defines */
#include "../object.h"
Copy link
Copy Markdown
Member

@vstinner vstinner Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that people should include pytime.h directly, and so I suggest to simply remove these includes. Let people respect the Python C API documentation which suggests to only include "Python.h".


/**************************************************************************
Expand Down