Skip to content

[3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708)#23866

Merged
pablogsal merged 1 commit into
python:3.9from
miss-islington:backport-a44ce6c-3.9
Dec 20, 2020
Merged

[3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708)#23866
pablogsal merged 1 commit into
python:3.9from
miss-islington:backport-a44ce6c-3.9

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Dec 20, 2020 •
edited by bedevere-bot
Loading

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo pablogsal@gmail.com
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus matti.picus@gmail.com

https://bugs.python.org/issue42604

@mattip @miss-islington
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using c…
0f4dcc4 
…onfigure (pythonGH-23708)

Now all platforms use a value for the "EXT_SUFFIX" build variable derived
from SOABI (for instance in FreeBSD, "EXT_SUFFIX" is now ".cpython-310d.so"
instead of ".so"). Previously only Linux, Mac and VxWorks were using a value
for "EXT_SUFFIX" that included "SOABI".

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a44ce6c)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 20, 2020
Merged
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Dec 20, 2020

@mattip and @pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Dec 20, 2020

@mattip and @pablogsal: Status check is done, and it's a failure ❌ .

@mattip
Copy link
Copy Markdown
Contributor

mattip commented Dec 20, 2020

I don’t think this failure is connected to the change

======================================================================
FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1548, in test_heading_callback
    simulate_heading_click(5, 5)
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1536, in simulate_heading_click
    self.assertEqual(self.tv.identify_region(x, y), 'heading')
AssertionError: 'nothing' != 'heading'
- nothing
+ heading


======================================================================
FAIL: test_variable_change (tkinter.test.test_ttk.test_extensions.LabeledScaleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 144, in test_variable_change
    self.assertGreater(x.scale.coords()[0], curr_xcoord)
AssertionError: 1 not greater than 1

@pablogsal pablogsal merged commit 4b15596 into python:3.9 Dec 20, 2020
@miss-islington miss-islington deleted the backport-a44ce6c-3.9 branch December 20, 2020 04:54
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented Dec 20, 2020

I don’t think this failure is connected to the change

======================================================================
FAIL: test_heading_callback (tkinter.test.test_ttk.test_widgets.TreeviewTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1548, in test_heading_callback
    simulate_heading_click(5, 5)
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1536, in simulate_heading_click
    self.assertEqual(self.tv.identify_region(x, y), 'heading')
AssertionError: 'nothing' != 'heading'
- nothing
+ heading


======================================================================
FAIL: test_variable_change (tkinter.test.test_ttk.test_extensions.LabeledScaleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_extensions.py", line 144, in test_variable_change
    self.assertGreater(x.scale.coords()[0], curr_xcoord)
AssertionError: 1 not greater than 1

Yep, that is some unrelated tkinter failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @mattip @pablogsal @the-knights-who-say-ni @bedevere-bot