Skip to content

Update stable ABI script for MacOS and update list of exported symbols #23783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Dec 15, 2020
Merged

Update stable ABI script for MacOS and update list of exported symbols #23783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Doc/data/stable_abi.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,7 @@ Py_FileSystemDefaultEncodeErrors
Py_FileSystemDefaultEncoding
Py_Finalize
Py_FinalizeEx
Py_FrozenMain
Copy link
Copy Markdown
Member

@vstinner vstinner Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-D

Copy link
Copy Markdown
Member Author

@pablogsal pablogsal Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make regen-limited-abi;)

Py_GenericAlias
Py_GenericAliasType
Py_GetBuildInfo
Expand Down
6 changes: 5 additions & 1 deletion Tools/scripts/stable_abi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"ucnhash.h",
}

MACOS = (sys.platform == "darwin")

def get_exported_symbols(library, dynamic=False):
# Only look at dynamic symbols
Expand All @@ -57,7 +58,10 @@ def get_exported_symbols(library, dynamic=False):
continue

symbol = parts[-1]
yield symbol
if MACOS and symbol.startswith("_"):
yield symbol[1:]
else:
yield symbol


def check_library(stable_abi_file, library, abi_funcs, dynamic=False):
Expand Down