Skip to content

bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function #23613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 6 commits into from
Dec 6, 2020
Merged

bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function #23613

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1bc3518
Check if NonCallableMock's spec_arg is not None instead of call its _…
Dec 2, 2020
81e35b9
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 2, 2020
d3b40aa
Update Misc/NEWS.d/next/Library/2020-12-02-07-37-59.bpo-42532.ObNep_.rst
idanw206 Dec 4, 2020
71c4f0c
Added test for unexpected call of when passing spec_arg in mock module
idanw206 Dec 5, 2020
190c9ed
Fixed whitespaces in testmock
Dec 6, 2020
b853185
Fixed whitespaces in testmock.py
idanw206 Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added test for unexpected call of when passing spec_arg in mock module
  • Loading branch information
@idanw206
idanw206 authored and Idan Weiss committed Dec 6, 2020
commit 71c4f0cb7c377664bdff7ece8a5c8c67c7411dc0
10 changes: 10 additions & 0 deletions Lib/unittest/test/testmock/testmock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2164,6 +2164,16 @@ def trace(frame, event, arg): # pragma: no cover
for mock in mocks:
obj = mock(spec=Something)
self.assertIsInstance(obj, Something)

def test_bool_not_called_when_passing_spec_arg(self):
class Something:
def __init__(self):
self.obj_with_bool_func = unittest.mock.MagicMock()

obj = Something()
with unittest.mock.patch.object(obj, 'obj_with_bool_func', autospec=True):
pass
self.assertEqual(obj.obj_with_bool_func.__bool__.call_count, 0)


if __name__ == '__main__':
Expand Down