Skip to content

bpo-39529: Deprecate creating new event loop in asyncio.get_event_loop() #23554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 12 commits into from
Apr 25, 2021
Merged

bpo-39529: Deprecate creating new event loop in asyncio.get_event_loop() #23554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fe6d8db
Deprecate creating new event loop in asyncio.get_event_loop()
serhiy-storchaka Nov 28, 2020
1b57659
Test with real running loop.
serhiy-storchaka Nov 30, 2020
b6c9546
Add more tests.
serhiy-storchaka Dec 6, 2020
d85dc62
Merge branch 'master' into asyncio-get_event_loop
serhiy-storchaka Dec 6, 2020
f972573
Revert some temporary changes.
serhiy-storchaka Dec 6, 2020
fba117d
Refactor _ensure_future().
serhiy-storchaka Dec 6, 2020
19ad168
Merge branch 'master' into asyncio-get_event_loop
serhiy-storchaka Dec 6, 2020
fe6a4f6
Rename tests.
serhiy-storchaka Dec 6, 2020
1eb0c5d
Simplify tests for gather() without arguments.
serhiy-storchaka Dec 6, 2020
b717f71
Add documentation.
serhiy-storchaka Dec 6, 2020
90e78bf
Rename some tests.
serhiy-storchaka Dec 6, 2020
eaa1cc1
Merge branch 'master' into asyncio-get_event_loop
serhiy-storchaka Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert some temporary changes.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 6, 2020
commit f972573e220708edec7bf58f1e3a0c350c97fd07
2 changes: 1 addition & 1 deletion Lib/asyncio/futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def _chain_future(source, destination):
raise TypeError('A future is required for source argument')
if not isfuture(destination) and not isinstance(destination,
concurrent.futures.Future):
raise TypeError('A future is required for destination argument %r' % destination)
raise TypeError('A future is required for destination argument')
source_loop = _get_loop(source) if isfuture(source) else None
dest_loop = _get_loop(destination) if isfuture(destination) else None

Expand Down
2 changes: 1 addition & 1 deletion Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def _all_tasks_compat(loop=None):
# the completed ones. Used to implement deprecated "Tasks.all_task()"
# method.
if loop is None:
loop = events._get_event_loop()
loop = events.get_event_loop()
# Looping over a WeakSet (_all_tasks) isn't safe as it can be updated from another
# thread while we do so. Therefore we cast it to list prior to filtering. The list
# cast itself requires iteration, so we repeat it several times ignoring
Expand Down