Skip to content

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 3 commits into from
Dec 18, 2020
Merged

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d178b6
Convert _sqlite3.Connection to Argument Clinic, part 1
Nov 17, 2020
feec909
Address review: set_authorizer() should also accept keyword arguments
Dec 18, 2020
dc1fd83
Address review: restore trace comment
Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review: restore trace comment
  • Loading branch information
Erlend E. Aasland committed Dec 18, 2020
commit dc1fd83dd6c55a2e22b4df4f225537e59e2456ec
8 changes: 7 additions & 1 deletion Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,13 @@ pysqlite_connection_set_trace_callback(pysqlite_Connection *self,
}

if (trace_callback == Py_None) {
/* None clears the trace callback previously set */
/*
* None clears the trace callback previously set
*
* Ref.
* - https://sqlite.org/c3ref/c_trace.html
* - https://sqlite.org/c3ref/trace_v2.html
*/
#ifdef HAVE_TRACE_V2
sqlite3_trace_v2(self->db, SQLITE_TRACE_STMT, 0, 0);
#else
Expand Down