Skip to content

Enable signing of nuget.org packages and update to supported timestamp server #23132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 3 commits into from
Nov 3, 2020
Merged

Enable signing of nuget.org packages and update to supported timestamp server #23132

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e39f4e9
Enable signing of nuget.org packages and update to supported timestam…
zooba Nov 3, 2020
83b4820
Sign and timestamp MSIX together
zooba Nov 3, 2020
55e6c08
Fix MSI signing step
zooba Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sign and timestamp MSIX together
  • Loading branch information
@zooba
zooba committed Nov 3, 2020
commit 83b4820e2d2f6b356379f5dd5522ee04612655f6
12 changes: 4 additions & 8 deletions .azure-pipelines/windows-release/stage-pack-msix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,25 +120,21 @@ jobs:
artifactName: unsigned_msix
downloadPath: $(Build.BinariesDirectory)

- powershell: |
signtool sign /a /n "$(SigningCertificate)" /fd sha256 /d "$(SigningDescription)" (gi *.msix)
displayName: 'Sign MSIX'
workingDirectory: $(Build.BinariesDirectory)\unsigned_msix

# MSIX must be signed and timestamped simultaneously
- powershell: |
$failed = $true
foreach ($retry in 1..3) {
signtool timestamp /tr http://timestamp.digicert.com/ /td sha256 (gi *.msix)
signtool sign /a /n "$(SigningCertificate)" /fd sha256 /tr http://timestamp.digicert.com/ /td sha256 /d "$(SigningDescription)" (gi *.msix)
if ($?) {
$failed = $false
break
}
sleep 1
}
if ($failed) {
throw "Failed to timestamp MSIX"
throw "Failed to sign MSIX"
}
displayName: 'Timestamp MSIX'
displayName: 'Sign MSIX'
workingDirectory: $(Build.BinariesDirectory)\unsigned_msix

- task: PublishBuildArtifacts@1
Expand Down