Skip to content

bpo-40077: Convert arraymodule to use heap types and establish module state #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 14 commits into from
Jan 2, 2021
+196 −159
Merged

bpo-40077: Convert arraymodule to use heap types and establish module state #23124

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
75e7622
Convert array type to heap type
Nov 3, 2020
7b8e273
Convert array iter type to heap type
Nov 3, 2020
3f78766
Establish global state and add types to it
Nov 3, 2020
23a582a
Remove unused check macro
Nov 3, 2020
1869a3a
Use local state variables iso. calling get_array_state() all the time
Nov 3, 2020
88d1928
Normalize array type names
Nov 3, 2020
d0ed2f7
Update clinic
Nov 3, 2020
a5798e2
Add NEWS
Nov 3, 2020
c3dfade
Use PyModule_AddType()
Nov 3, 2020
aa3bd22
Migrate from global to module state
Nov 3, 2020
656c5d0
Fix NEWS
Nov 3, 2020
72434ad
Address review comment: adjust naming to reflect time complexity
Nov 4, 2020
b86185d
Merge branch 'master' into bpo-40077/array
Dec 16, 2020
f864969
Address review: Wrap state exclusively used in asserts in #ifndef NDEBUG
Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use PyModule_AddType()
  • Loading branch information
Erlend E. Aasland committed Nov 3, 2020
commit c3dfade9c4558bcadcbc48e97dd0a7c7ab6f2d7a
4 changes: 1 addition & 3 deletions Modules/arraymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3005,9 +3005,7 @@ array_modexec(PyObject *m)
}
Py_DECREF(res);

Py_INCREF((PyObject *)state->ArrayType);
if (PyModule_AddObject(m, "array", (PyObject *)state->ArrayType) < 0) {
Py_DECREF((PyObject *)state->ArrayType);
if (PyModule_AddType(m, state->ArrayType) < 0) {
return -1;
}

Expand Down