Skip to content

bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction#23026

Merged
ambv merged 1 commit into
python:mainfrom
shangxiao:update_booleanoptionalaction_new_in_version
Jul 12, 2021
Merged

bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction#23026
ambv merged 1 commit into
python:mainfrom
shangxiao:update_booleanoptionalaction_new_in_version

Conversation

@shangxiao
Copy link
Copy Markdown
Contributor

@shangxiao shangxiao commented Oct 29, 2020 •
edited by bedevere-bot
Loading

Hi :)

Just noticed that docs for argparse.BooleanOptionalAction is missing the "New in version" label as it seems to be a recent addition in 3.9.0. I'm assuming this will require a backport to a 3.9.x branch?

Cheers!

https://bugs.python.org/issue42194

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Oct 29, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shangxiao

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 29, 2020
@ammaraskar
Copy link
Copy Markdown
Member

ammaraskar commented Oct 29, 2020

For other reviewer's reference, this was added as part of 6a517c6

It looks like this was also missed in 3.9 whatsnew https://docs.python.org/3/whatsnew/3.9.html#improved-modules

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
nanjekyejoannah
nanjekyejoannah reviewed Jun 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an update to whatsnew @rhettinger ? Otherwise, this is okay to merge.

It's a small fix and we can merge without CLA, but the author is advised to sign the CLA for future contributions.

@nanjekyejoannah nanjekyejoannah mentioned this pull request Jun 7, 2021
Closed
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 12, 2021
@ambv ambv merged commit da2e673 into python:main Jul 12, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 12, 2021

Thanks @shangxiao for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
@shangxiao @miss-islington
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
5aee7d2 
pythonGH-23026)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 12, 2021

GH-27097 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 12, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
@shangxiao @miss-islington
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
ac7cc7d 
pythonGH-23026)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
ambv pushed a commit that referenced this pull request Jul 12, 2021
@miss-islington @shangxiao
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
721d479 
GH-23026) (#27097)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 12, 2021

Thanks @shangxiao for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

ambv pushed a commit that referenced this pull request Jul 12, 2021
@miss-islington @shangxiao
bpo-42194: Add "New in version: 3.9" to argparse.BooleanOptionalAction (
c786988 
GH-23026) (#27098)

(cherry picked from commit da2e673)

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
@ambv
Copy link
Copy Markdown
Contributor

ambv commented Jul 12, 2021

3.9 backport was #27098

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shangxiao @the-knights-who-say-ni @ammaraskar @miss-islington @bedevere-bot @ambv @nanjekyejoannah