Skip to content

bpo-41818: Updated tests for the standard pty library #22962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 10 commits into from
Nov 25, 2020
Merged

bpo-41818: Updated tests for the standard pty library #22962

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
323fc9c
Updated tests for the pty standard library
8vasu Oct 25, 2020
4bb22ca
In Lib/test/test_pty.py, wrap @expectedFailure to check if pty.STDIN_…
8vasu Oct 25, 2020
a8723e7
In Lib/test/test_pty.py, add a check for "Darwin" in expectedFailureO…
8vasu Oct 25, 2020
26c0928
Remove some comments.
8vasu Oct 26, 2020
9a6e70f
Restructure the tests, perform cleanup.
8vasu Nov 2, 2020
f6d01f8
Restructure test_openpty().
8vasu Nov 2, 2020
85f173b
Restructure test_openpty().
8vasu Nov 2, 2020
6546938
Restructure test_openpty().
8vasu Nov 2, 2020
0cde3f2
Remove/change some comments.
8vasu Nov 20, 2020
e990b79
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove/change some comments. 
Signed-off-by: Soumendra Ganguly <soumendraganguly@gmail.com>
  • Loading branch information
@8vasu
8vasu committed Nov 20, 2020
commit 0cde3f28ff866af19da331c1aace5439846dd21a
4 changes: 1 addition & 3 deletions Lib/test/test_pty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ def setUp(self):
self.stdin_cols, 0, 0)
self.addCleanup(_set_term_winsz, pty.STDIN_FILENO, old_stdin_winsz)
except OSError:
# possible reason: current stdin is not a tty
pass

def handle_sig(self, sig, frame):
Expand All @@ -145,7 +144,7 @@ def test_openpty(self):
try:
mode = tty.tcgetattr(pty.STDIN_FILENO)
except tty.error:
# possible reason: current stdin is not a tty
# not a tty or bad/closed fd
debug("tty.tcgetattr(pty.STDIN_FILENO) failed")
mode = None

Expand All @@ -165,7 +164,6 @@ def test_openpty(self):
self.assertEqual(new_stdin_winsz, target_stdin_winsz,
"pty.STDIN_FILENO window size unchanged")
except OSError:
# possible reason: current stdin is not a tty
warnings.warn("Failed to set pty.STDIN_FILENO window size")
pass

Expand Down