Skip to content

bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creating the func object #22953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Oct 29, 2020
Merged

bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creating the func object #22953

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57b3641
bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creat…
Jongy Oct 24, 2020
44efc82
Add NEWS entry
Jongy Oct 27, 2020
67c0bc1
Add missing XDECREF
Jongy Oct 27, 2020
ecf9d50
Fix broken spacing
Jongy Oct 27, 2020
52c1da4
Fix RST syntax
Jongy Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix broken spacing
  • Loading branch information
@Jongy
Jongy committed Oct 27, 2020
commit ecf9d501ca689c09eeffafa7e3d981b3e584ea79
2 changes: 1 addition & 1 deletion Objects/funcobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ PyFunction_NewWithQualName(PyObject *code, PyObject *globals, PyObject *qualname
}

/* __module__: If module name is in globals, use it.
Otherwise, use None. */
Otherwise, use None. */
module = PyDict_GetItemWithError(globals, __name__);
Copy link
Copy Markdown
Contributor Author

@Jongy Jongy Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now runs before Py_INCREF(globals), not sure if relevant (because our caller should hold a reference to globals, right?)

Can put Py_INCREF(globals) before this call.

if (module) {
Py_INCREF(module);
Expand Down