bpo-42127: Document effect of cached_property on key-sharing dicts#22930
Merged
Conversation
Jongy
approved these changes
Oct 24, 2020
Contributor
Jongy
left a comment
There was a problem hiding this comment.
Not a core reviewer, but LGTM :)
The workaround is nice but perhaps you could add a word on the performance hit it gives? That is, by avoiding the insertion of a new dict key, you'll have slower code when accessing the already-cached object.
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2020
…ries (pythonGH-22930) (cherry picked from commit 48be6b1) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
|
GH-22955 is a backport of this pull request to the 3.9 branch. |
rhettinger
pushed a commit
that referenced
this pull request
Oct 25, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42127