Skip to content

bpo-41995 :fix five possible Null Pointer Dereference bugs.#22635

Merged
vstinner merged 1 commit into
python:masterfrom
Yunlongs:fix-nullpointer
Jan 20, 2021
Merged

bpo-41995 :fix five possible Null Pointer Dereference bugs.#22635
vstinner merged 1 commit into
python:masterfrom
Yunlongs:fix-nullpointer

Conversation

@Yunlongs
Copy link
Copy Markdown
Contributor

@Yunlongs Yunlongs commented Oct 10, 2020 •
edited by bedevere-bot
Loading

fix five possible null pointer dereference bugs in https://bugs.python.org/issue41995.

https://bugs.python.org/issue41995

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Oct 10, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Yunlongs

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

vstinner
vstinner reviewed Oct 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write a separated PR for the tracemalloc fix? It should be backported up to 3.8, whereas the zoneinfo fix should only be backported up to 3.9. It's just more convenient to have two separated PR.

The tracemalloc fix is correct :-)

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Oct 11, 2020

cc @pganssle for the zoneinfo fix ;-)

@Yunlongs
Copy link
Copy Markdown
Contributor Author

Yunlongs commented Oct 12, 2020

Can you please write a separated PR for the tracemalloc fix? It should be backported up to 3.8, whereas the zoneinfo fix should only be backported up to 3.9. It's just more convenient to have two separated PR.

The tracemalloc fix is correct :-)

#22660

@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Oct 12, 2020 •
edited
Loading

Please add also a NEWS entry if this bug affects behavior and don't forget to sign the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@Yunlongs
Copy link
Copy Markdown
Contributor Author

Yunlongs commented Dec 23, 2020

Please add also a NEWS entry if this bug affects behavior and don't forget to sign the CLA.

Where to add NEWS entry?

@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Dec 23, 2020

https://devguide.python.org/committing/#what-s-new-and-news-entries

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 24, 2020
@vstinner vstinner merged commit f1ff800 into python:master Jan 20, 2021
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jan 20, 2021

This PR is stale since October 2020. I prefer to merge it without document it rather than keeping the bugs.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jan 20, 2021

Thanks @Yunlongs for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
@Yunlongs @miss-islington
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (p…
dc515e8 
…ythonGH-22635)

(cherry picked from commit f1ff800)

Co-authored-by: Yunlongs <lylgood@foxmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 20, 2021

GH-24261 is a backport of this pull request to the 3.9 branch.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jan 20, 2021

Oh, _tracemalloc was fixed in commit 66c28f5.

miss-islington added a commit that referenced this pull request Jan 20, 2021
@miss-islington @Yunlongs
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (G…
50938b6 
…H-22635)

(cherry picked from commit f1ff800)

Co-authored-by: Yunlongs <lylgood@foxmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Yunlongs @adorilson
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (p…
8b3feec 
…ythonGH-22635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@pganssle pganssle Awaiting requested review from pganssle

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Yunlongs @the-knights-who-say-ni @vstinner @serhiy-storchaka @miss-islington @bedevere-bot @corona10 @pablogsal