Skip to content

bpo-41905: added abc.update_abstractmethods #22485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 21 commits into from
Oct 6, 2020
Merged

bpo-41905: added abc.update_abstractmethods #22485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f65b0f8
added update_abstractmethods
Oct 1, 2020
c04ba74
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 1, 2020
ea69ae6
fix whitespaces
Oct 1, 2020
8b76715
Merge branch 'master' of https://github.com/bentheiii/cpython into ma…
Oct 1, 2020
61c4f40
documentation fixes
Oct 1, 2020
a5a9fd7
additional tests
Oct 1, 2020
5e1fffc
rename test
Oct 1, 2020
2f95b84
added explicit check for ABCMeta
Oct 1, 2020
3986c98
optimization on total_ordering
Oct 2, 2020
4f3d846
update_abstractmethods now ignores non-abstract classes
Oct 3, 2020
74473c8
total_ordering now only overrides abtract methods defined in supercla…
Oct 3, 2020
92326c9
doc fix
Oct 3, 2020
1e47ee4
excluded total_ordering from this issue
Oct 3, 2020
740183f
documented ABC being ABC unaware
Oct 3, 2020
114028e
fixed potential bug with deletion of implementation
Oct 4, 2020
ba8df08
added layered test case
Oct 4, 2020
29dba37
update_abstractmethods doesn't care about subclasses for now
Oct 4, 2020
779e6cf
doc fixes
Oct 4, 2020
eea97f4
Update Doc/library/abc.rst
bentheiii Oct 5, 2020
8eec6c2
Update Lib/abc.py
bentheiii Oct 5, 2020
5698153
Update Lib/abc.py
bentheiii Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
documented ABC being ABC unaware
  • Loading branch information
ben avrahami committed Oct 3, 2020
commit 740183fe8a03abf9b4814c2a942198020e5dd019
7 changes: 7 additions & 0 deletions Doc/library/functools.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,13 @@ The :mod:`functools` module defines the following functions:
application, implementing all six rich comparison methods instead is
likely to provide an easy speed boost.

.. note::

This decorator makes no attempt to override methods that have been
declared in the class *or its superclasses*. Meaning that if a
superclass defines a comparison operator, *total_ordering* will not
implement it again, even if the original method is abstract.

.. versionadded:: 3.2

.. versionchanged:: 3.4
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2020-10-01-21-11-03.bpo-41905._JpjR4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
A new function in abc: *update_abstractmethods* to re-calculate an abstract class's abstract status. In addition, *dataclass* and *total_ordering* have been changed to call this function. Finally, *total_ordering* was patched so that it would override abstract methods defined in superclasses.
A new function in abc: *update_abstractmethods* to re-calculate an abstract class's abstract status. In addition, *dataclass* has been changed to call this function.