Skip to content

bpo-41842: Add a unregister function in _codecs module #22360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 15 commits into from
Sep 28, 2020
Merged

bpo-41842: Add a unregister function in _codecs module #22360

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fefda70
add a _codecs.unregister in _codecs module
shihai1991 Sep 22, 2020
f7775c0
apply victor's comment
shihai1991 Sep 23, 2020
71b624e
apply victor's comment
shihai1991 Sep 23, 2020
d186726
apply victor's comment
shihai1991 Sep 24, 2020
f8e912b
retrigger checks
shihai1991 Sep 24, 2020
40666fc
apply victor's comment
shihai1991 Sep 24, 2020
3257b6c
update doc
shihai1991 Sep 24, 2020
a493a35
update doc
shihai1991 Sep 24, 2020
e29ec44
Merge remote-tracking branch 'origin/master' into bpo_39337_new_3
shihai1991 Sep 24, 2020
db4631e
update doc
shihai1991 Sep 24, 2020
5efff22
apply victor's comment
shihai1991 Sep 24, 2020
f18cd4f
apply Dong-hee Na's comment
shihai1991 Sep 26, 2020
8f6dc4d
apply victor and Zackery's comment
shihai1991 Sep 26, 2020
4308ea8
apply victor's comment
shihai1991 Sep 26, 2020
c9a0c99
apply victor's comment
shihai1991 Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply victor's comment
  • Loading branch information
@shihai1991
shihai1991 committed Sep 24, 2020
commit 5efff220fb0ba9c3bac3454ecbce56fb7f87edf0
3 changes: 1 addition & 2 deletions Doc/whatsnew/3.10.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ codecs
------

Add a :func:`codecs.unregister` to unregister a codec search function.
Comment thread
shihai1991 marked this conversation as resolved.
Outdated
Comment thread
shihai1991 marked this conversation as resolved.
Outdated
(Contributed by Hai Shi in :issue:`41842`.)

curses
------
Expand Down Expand Up @@ -245,8 +246,6 @@ New Features
* Add a :c:func:`PyCodec_Unregister` to unregister a codec search function.
Comment thread
shihai1991 marked this conversation as resolved.
Outdated
(Contributed by Hai Shi in :issue:`41842`.)

=======

Porting to Python 3.10
----------------------

Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,6 +1648,7 @@ def test_unregister(self):
self.assertRaises(TypeError, codecs.lookup, name)
search_function.assert_called_with(name)
search_function.reset_mock()
Comment thread
shihai1991 marked this conversation as resolved.

codecs.unregister(search_function)
self.assertRaises(LookupError, codecs.lookup, name)
search_function.assert_not_called()
Expand Down