Skip to content

bpo-41780: Fix __dir__ of types.GenericAlias - #22262

Merged
miss-islington merged 3 commits into
python:masterfrom
isidentical:bpo-41780
Sep 15, 2020
Merged

miss-islington merged 3 commits into
python:masterfrom
isidentical:bpo-41780

Conversation

@isidentical

@isidentical isidentical commented Sep 15, 2020 •

Copy link
Copy Markdown
Member

Comment thread Objects/genericaliasobject.c Outdated
Comment thread Objects/genericaliasobject.c Outdated
Comment thread Objects/genericaliasobject.c Outdated
Comment thread Objects/genericaliasobject.c Outdated
Co-authored-by: Guido van Rossum <guido@python.org>

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@isidentical

isidentical commented Sep 15, 2020 •

Copy link
Copy Markdown
Member Author

Backport to 3.9? nvm, you already added

@gvanrossum

Copy link
Copy Markdown
Member

This presumably won't make it into 3.9.0 (IIUC rc2 is being cut as we speak and final is in three weeks; this just isn't important enough), but it should be fixed in 3.9.1.

@miss-islington

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 2e87774 into python:master Sep 15, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2020
Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 2e87774)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-22264 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 15, 2020
Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 2e87774)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants