Skip to content

bpo-1635741: - port overlapped to multi-phase #22051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Sep 7, 2020
Merged

bpo-1635741: - port overlapped to multi-phase #22051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3914dfe
port overlapped to multi-phase
koubaa Aug 11, 2020
3da5102
blurb
koubaa Sep 1, 2020
cb97040
don'tuse PyModule_GetDict
koubaa Sep 5, 2020
b00a02d
minor change
koubaa Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
minor change
  • Loading branch information
@koubaa
koubaa committed Sep 7, 2020
commit b00a02d77abb9ef58ad4b65a564300e3bbd31c00
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core and Builtins/2020-09-01-17-22-35.bpo-1635741.CnRME3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Port the :mod:`overlapped` extension module to multi-phase initialization
Port the :mod:`_overlapped` extension module to multi-phase initialization
(:pep:`489`).
3 changes: 2 additions & 1 deletion Modules/overlapped.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,8 +1942,9 @@ overlapped_exec(PyObject *module)

Py_DECREF(socket_module);

if (initialize_function_pointers() < 0)
if (initialize_function_pointers() < 0) {
return -1;
}

OverlappedState *st = overlapped_get_state(module);
st->overlapped_type = (PyTypeObject *)PyType_FromModuleAndSpec(
Expand Down