Skip to content

bpo-41687: Fix sendfile implementation to work with Solaris #22040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 4 commits into from
Sep 5, 2020
Merged

bpo-41687: Fix sendfile implementation to work with Solaris #22040

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
769ef15
bpo-41687: Fix sendfile implementation on Solaris
kulikjak Sep 1, 2020
5c126fe
add news entry
kulikjak Sep 1, 2020
94cbb65
Add comment summarizing the issue
kulikjak Sep 2, 2020
bfbdcbb
Added test skip explanation
kulikjak Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment summarizing the issue
  • Loading branch information
@kulikjak
kulikjak committed Sep 2, 2020
commit 94cbb652e0e62d5698f04a1384e5339dc410d14e
2 changes: 2 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9519,6 +9519,8 @@ os_sendfile_impl(PyObject *module, int out_fd, int in_fd, PyObject *offobj,
return NULL;

#if defined(__sun) && defined(__SVR4)
Comment thread
kulikjak marked this conversation as resolved.
// On Solaris, sendfile raises EINVAL rather than returning 0
// when the offset is equal or bigger than the in_fd size.
int res;
struct stat st;

Expand Down