bpo-41617: check for bswap builtins before using#21942
Closed
jmroot wants to merge 1 commit into
Closed
Conversation
Don't assume clang always has them; use __has_builtin to check.
jmroot
added a commit
to jmroot/cpython
that referenced
this pull request
Aug 23, 2020
Don't assume clang always has them; use __has_builtin to check.
vstinner
reviewed
Aug 24, 2020
| ((__GNUC__ >= 5) || (__GNUC__ == 4) && (__GNUC_MINOR__ >= 8))) | ||
| // Don't break compilers that don't know about __has_builtin | ||
| #ifndef __has_builtin | ||
| # define __has_builtin(x) 0 |
Member
There was a problem hiding this comment.
I dislike mocking this function. So I wrote a different fix: PR #21949.
Member
|
I merged the simple PR #22042 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't assume clang always has them; use __has_builtin to check.
https://bugs.python.org/issue41617