[3.9] bpo-41568: Fix refleaks in zoneinfo subclasses (GH-21907)#21912
Merged
Conversation
* Fix refleak in C module __init_subclass__ This was leaking a reference to the weak cache dictionary for every ZoneInfo subclass created. * Fix refleak in ZoneInfo subclass's clear_cache The previous version of the code accidentally cleared the global ZONEINFO_STRONG_CACHE variable (and inducing `ZoneInfo` to create a new strong cache) on calls to a subclass's `clear_cache()`. This would not affect guaranteed behavior, but it's still not the right thing to do (and it caused reference leaks). (cherry picked from commit c3dd7e4) Co-authored-by: Paul Ganssle <paul@ganssle.io>
Member
|
@ambv This should go in the rc2 if that is possible :) |
Contributor
Author
|
@pganssle and @pablogsal: Status check is done, and it's a success ✅ . |
pganssle
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was leaking a reference to the weak cache dictionary for every
ZoneInfo subclass created.
The previous version of the code accidentally cleared the global
ZONEINFO_STRONG_CACHE variable (and inducing
ZoneInfoto create a newstrong cache) on calls to a subclass's
clear_cache(). This would notaffect guaranteed behavior, but it's still not the right thing to do
(and it caused reference leaks).
(cherry picked from commit c3dd7e4)
Co-authored-by: Paul Ganssle paul@ganssle.io
https://bugs.python.org/issue41568