Skip to content

bpo-1635741: Port hashlib modules to multiphase init (PEP 489) #21818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 15 commits into from
Sep 6, 2020
Merged

bpo-1635741: Port hashlib modules to multiphase init (PEP 489) #21818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4ae1a3f
port sha1
koubaa Aug 10, 2020
b389566
port sha512
koubaa Aug 10, 2020
8add6b1
port md5
koubaa Aug 10, 2020
3ff18f7
blurb
koubaa Aug 10, 2020
9388486
address comments
koubaa Aug 21, 2020
e0c0feb
remove unneeded comment
koubaa Aug 21, 2020
6c7f435
fix use-after-free
koubaa Aug 28, 2020
37e2282
add traverse/clear/free module methods
koubaa Aug 28, 2020
0384e6b
resolve comments
koubaa Aug 29, 2020
2cfcb12
pep7
koubaa Aug 29, 2020
4bcb57f
fix dealloc function
koubaa Aug 29, 2020
3cd5d6e
update based on PR review
koubaa Sep 1, 2020
0244bcf
use defining_class
koubaa Sep 2, 2020
b66a965
remove comment
koubaa Sep 3, 2020
df69769
fix readme
koubaa Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix use-after-free
  • Loading branch information
@koubaa
koubaa committed Aug 31, 2020
commit 6c7f4352ee3a73cfc212f4ba99615357cca9be1c
2 changes: 1 addition & 1 deletion Modules/md5module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ newMD5object(MD5State * st)
static void
MD5_dealloc(PyObject *ptr)
{
PyObject_Del(ptr);
Py_DECREF(Py_TYPE(ptr));
PyObject_Del(ptr);
}


Expand Down
2 changes: 1 addition & 1 deletion Modules/sha1module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ newSHA1object(SHA1State *st)
static void
SHA1_dealloc(PyObject *ptr)
{
PyObject_Del(ptr);
Py_DECREF(Py_TYPE(ptr));
PyObject_Del(ptr);
}


Expand Down
2 changes: 1 addition & 1 deletion Modules/sha512module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ static SHAobject *newSHA512object(SHA512State *st) {
static void
SHA512_dealloc(PyObject *ptr)
{
PyObject_Del(ptr);
Py_DECREF(Py_TYPE(ptr));
PyObject_Del(ptr);
}


Expand Down