bpo-41515: prevent get_type_hints from raising KeyError#21816
Conversation
typing.get_type_hints raises KeyError on synthetic modules that don't appear in sys.modules.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
gvanrossum
left a comment
There was a problem hiding this comment.
Sorry for sitting on this so long. Can you prepare a short blurb too?
|
Also please rebase, it might fix the macOS test failure. |
|
I have created #25352 with attribution to author since I don't have permission to update the PR. Thanks. |
|
Closed in favor of GH-25352. |
https://bugs.python.org/issue41515