Skip to content

bpo-41424: Remove extra words in Tkinter-Packer documentation#21707

Merged
terryjreedy merged 1 commit into
python:masterfrom
nmaynes:master
Aug 3, 2020
Merged

bpo-41424: Remove extra words in Tkinter-Packer documentation#21707
terryjreedy merged 1 commit into
python:masterfrom
nmaynes:master

Conversation

@nmaynes
Copy link
Copy Markdown
Contributor

@nmaynes nmaynes commented Aug 3, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 3, 2020
terryjreedy
terryjreedy approved these changes Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge as is.

Comment thread Doc/library/tkinter.rst
packer takes qualitative relationship specification - *above*, *to the left of*,
*filling*, etc - and works everything out to determine the exact placement
coordinates for you.
are used to specify the relative positioning of widgets within their container -
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: the source .rst files are not required to have their lines nicely filled out before being wrapped. You could have merely removed the extra from one line and left the rest alone. I then would have been required to check only the one line.

Copy link
Copy Markdown
Contributor Author

@nmaynes nmaynes Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out @terryjreedy. I appreciate your guidance and will remember that for next time!

@terryjreedy terryjreedy added needs backport to 3.8 skip news type-bug An unexpected behavior, bug, or error labels Aug 3, 2020
@terryjreedy terryjreedy merged commit ecaf949 into python:master Aug 3, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 3, 2020

Thanks @nmaynes for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 3, 2020

GH-21708 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2020
@nmaynes @miss-islington
bpo-41424: Remove extra words in Tkinter-Packer documentation (python…
c230b38 
…GH-21707)

(cherry picked from commit ecaf949)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
@terryjreedy terryjreedy changed the title bpo-41424 Corrected grammatical error in Tkinter-Packer documentation bpo-41424: Corrected grammatical error in Tkinter-Packer documentation Aug 3, 2020
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 3, 2020

GH-21709 is a backport of this pull request to the 3.8 branch.

@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Aug 3, 2020

There should be a ':' after the issue number.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2020
@nmaynes @miss-islington
bpo-41424: Remove extra words in Tkinter-Packer documentation (python…
3178e5f 
…GH-21707)

(cherry picked from commit ecaf949)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
@terryjreedy terryjreedy changed the title bpo-41424: Corrected grammatical error in Tkinter-Packer documentation bpo-41424: Remove extra words in Tkinter-Packer documentation Aug 3, 2020
miss-islington added a commit that referenced this pull request Aug 3, 2020
@miss-islington @nmaynes
bpo-41424: Remove extra words in Tkinter-Packer documentation (GH-21707)
905c7de 
(cherry picked from commit ecaf949)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
miss-islington added a commit that referenced this pull request Aug 3, 2020
@miss-islington @nmaynes
bpo-41424: Remove extra words in Tkinter-Packer documentation (GH-21707)
45d37cb 
(cherry picked from commit ecaf949)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@nmaynes @shihai1991
bpo-41424: Remove extra words in Tkinter-Packer documentation (python…
dd7378e 
…GH-21707)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@nmaynes @shihai1991
bpo-41424: Remove extra words in Tkinter-Packer documentation (python…
a6cced6 
…GH-21707)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@nmaynes @xzy3-cdc
bpo-41424: Remove extra words in Tkinter-Packer documentation (python…
b6dfc17 
…GH-21707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nmaynes @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni