bpo-41410: Fix outdated info in mkstemp docs#21701
Conversation
Choosing to open a file in binary or text mode makes a difference on *all* platforms since Python 3.x
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
ericvsmith
left a comment
There was a problem hiding this comment.
One small point about truthiness.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
|
I have made the requested changes; please review again @ericvsmith I didn’t quite get what you. Is this what you meant? |
|
Thanks for making the requested changes! @ericvsmith, @rhettinger: please review the changes made to this pull request. |
ericvsmith
left a comment
There was a problem hiding this comment.
When this small issue is addressed and the CLA is signed, we can merge this.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ericvsmith, @rhettinger: please review the changes made to this pull request. |
ericvsmith
left a comment
There was a problem hiding this comment.
This looks good, thanks. Now it's just waiting on the CLA (Contributor License Agreement).
|
Hi do I need to do anything else here? |
|
Thanks @xrisk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68) Co-authored-by: Rishav Kundu <rk@rishav.io>
|
GH-21873 is a backport of this pull request to the 3.9 branch. |
|
GH-21874 is a backport of this pull request to the 3.8 branch. |
|
GH-21875 is a backport of this pull request to the 3.7 branch. |
Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68) Co-authored-by: Rishav Kundu <rk@rishav.io>
Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68) Co-authored-by: Rishav Kundu <rk@rishav.io>
Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68) Co-authored-by: Rishav Kundu <rk@rishav.io>
Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68) Co-authored-by: Rishav Kundu <rk@rishav.io>
Automerge-Triggered-By: @ericvsmith
Automerge-Triggered-By: @ericvsmith
https://bugs.python.org/issue41410
Automerge-Triggered-By: @ericvsmith