Skip to content

[3.8] bpo-41384: Raise TclError in tkinter.OptionMenu (GH-21601)#21636

Merged
terryjreedy merged 1 commit into
python:3.8from
miss-islington:backport-f1d40f9-3.8
Jul 27, 2020
Merged

[3.8] bpo-41384: Raise TclError in tkinter.OptionMenu (GH-21601)#21636
terryjreedy merged 1 commit into
python:3.8from
miss-islington:backport-f1d40f9-3.8

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jul 27, 2020 •
edited by bedevere-bot
Loading

... when an unknown option is passed. TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
(cherry picked from commit f1d40f9)

Co-authored-by: Akuli akuviljanen17@gmail.com

https://bugs.python.org/issue41384

@Akuli @miss-islington
bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)
8a03f51 
... when an unknown option is passed.  TypeError was being raised because a 2to3 fix was missing.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit f1d40f9)

Co-authored-by: Akuli <akuviljanen17@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 27, 2020
Merged
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jul 27, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Akuli

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Jul 27, 2020
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jul 27, 2020

@Akuli and @terryjreedy: Status check is done, and it's a success ✅ .

@terryjreedy terryjreedy merged commit 104aded into python:3.8 Jul 27, 2020
@miss-islington miss-islington deleted the backport-f1d40f9-3.8 branch July 27, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @the-knights-who-say-ni @terryjreedy @bedevere-bot @Akuli