Skip to content

bpo-41316: Make tarfile follow specs for FNAME #21511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 6 commits into from
Sep 7, 2020
+17 −1
Merged

bpo-41316: Make tarfile follow specs for FNAME #21511

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5639f66
bpo-41316: Make tarfile follow specs for FNAME
ArtemSBulgakov Jul 16, 2020
6f751fe
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 28, 2020
4a8bd29
Update ACKS
ArtemSBulgakov Jul 28, 2020
3948880
Add test capturing missed expectation when the path appears in the re…
jaraco Sep 7, 2020
0bbaa1c
Merge branch 'bpo-41316-test' into bpo-41316
jaraco Sep 7, 2020
4baaf5e
Reference RFC and precise language for easier searching.
jaraco Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-41316: Make tarfile follow specs for FNAME 
tarfile writes full path to FNAME field of GZIP format instead of just basename if user specified absolute path. Some archive viewers may process file incorrectly. Also it creates security issue because anyone can know structure of directories on system and know username or other personal information.

RFC1952 says about FNAME:
This is the original name of the file being compressed, with any directory components removed.

So tarfile must remove directory names from FNAME and write only basename of file.
  • Loading branch information
@ArtemSBulgakov
ArtemSBulgakov committed Jul 28, 2020
commit 5639f66f6707bf3f41a0bbd09318ab1c4b6e1b29
2 changes: 2 additions & 0 deletions Lib/tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,8 @@ def _init_write_gz(self):
self.__write(b"\037\213\010\010" + timestamp + b"\002\377")
if self.name.endswith(".gz"):
self.name = self.name[:-3]
# Remove directory components
Comment thread
jaraco marked this conversation as resolved.
Outdated
self.name = os.path.basename(self.name)
Comment thread
ArtemSBulgakov marked this conversation as resolved.
Outdated
# RFC1952 says we must use ISO-8859-1 for the FNAME field.
self.__write(self.name.encode("iso-8859-1", "replace") + NUL)

Expand Down