Skip to content

bpo-41273: asyncio's proactor read transport's better performance by using recv_into instead of recv #21442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 2 commits into from
Jul 14, 2020
Merged

bpo-41273: asyncio's proactor read transport's better performance by using recv_into instead of recv #21442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d147074
bpo-41273: Proactor transport read loop to use recv_into
tontinton Jul 10, 2020
357a3f5
bpo-41273: Double proactor read transport buffer size
tontinton Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-41273: Double proactor read transport buffer size 
By doubling the read buffer size we get better performance.
  • Loading branch information
@tontinton
tontinton committed Jul 11, 2020
commit 357a3f5efebad24f37bc3277c426834bb7f4d396
2 changes: 1 addition & 1 deletion Lib/asyncio/proactor_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class _ProactorReadPipeTransport(_ProactorBasePipeTransport,
"""Transport for read pipes."""

def __init__(self, loop, sock, protocol, waiter=None,
extra=None, server=None, buffer_size=32768):
extra=None, server=None, buffer_size=65536):
self._pending_data_length = -1
self._paused = True
super().__init__(loop, sock, protocol, waiter, extra, server)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_proactor_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def setUp(self):
self.loop._proactor = self.proactor
self.protocol = test_utils.make_test_protocol(asyncio.Protocol)
self.sock = mock.Mock(socket.socket)
self.buffer_size = 32768
self.buffer_size = 65536

def socket_transport(self, waiter=None):
transport = _ProactorSocketTransport(self.loop, self.sock,
Expand Down