Skip to content

bpo-41242: When concating strings, I think it is better to use += than join the list#21397

Closed
archsyscall wants to merge 1 commit into
python:masterfrom
archsyscall:fix-issue-41242
Closed

bpo-41242: When concating strings, I think it is better to use += than join the list#21397
archsyscall wants to merge 1 commit into
python:masterfrom
archsyscall:fix-issue-41242

Conversation

@archsyscall
Copy link
Copy Markdown
Contributor

@archsyscall archsyscall commented Jul 8, 2020

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@marload

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marload, thanks for looking for ways to improve Python!

As I commented on the issue in BPO, I think the current code is correct and does not need to be changed. Please don't hesitate to look for other issues to work on at https://bugs.python.org!

@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Jul 8, 2020

Please see discussion on https://bugs.python.org/issue41242 for the closing reason

@asvetlov asvetlov closed this Jul 8, 2020
@archsyscall
Copy link
Copy Markdown
Contributor Author

@remilapeyre
Thank you very much for your response. I am sorry that this change was rejected, but I will continue to contribute.

@archsyscall archsyscall deleted the fix-issue-41242 branch July 8, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants