Skip to content

bpo-41132: Use pymalloc allocator in the f-string parser#21173

Merged
pablogsal merged 1 commit into
python:masterfrom
lysnikolaou:allocator
Jun 27, 2020
Merged

bpo-41132: Use pymalloc allocator in the f-string parser#21173
pablogsal merged 1 commit into
python:masterfrom
lysnikolaou:allocator

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented Jun 27, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner June 27, 2020 07:55
ericvsmith
ericvsmith reviewed Jun 27, 2020
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 6dcbc24 into python:master Jun 27, 2020
@miss-islington

miss-islington commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Sorry, @lysnikolaou and @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6dcbc2422de9e2a7ff89a4689572d84001e230b2 3.9

@miss-islington

miss-islington commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Sorry @lysnikolaou and @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6dcbc2422de9e2a7ff89a4689572d84001e230b2 3.8

@pablogsal

pablogsal commented Jun 27, 2020

Copy link
Copy Markdown
Member

@lysnikolaou Manual backport party 🎉

@lysnikolaou

lysnikolaou commented Jun 27, 2020

Copy link
Copy Markdown
Member Author

@lysnikolaou Manual backport party 🎉

On it!

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Jun 27, 2020
@lysnikolaou
[3.9] bpo-41132: Use pymalloc allocator in the f-string parser (pytho…
299dac8 
…nGH-21173)

(cherry picked from commit 6dcbc24)
@bedevere-bot

bedevere-bot commented Jun 27, 2020

Copy link
Copy Markdown

GH-21183 is a backport of this pull request to the 3.9 branch.

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Jun 27, 2020
@lysnikolaou
[3.8] bpo-41132: Use pymalloc allocator in the f-string parser (pytho…
b4fe47f 
…nGH-21173)
@bedevere-bot

bedevere-bot commented Jun 27, 2020

Copy link
Copy Markdown

GH-21184 is a backport of this pull request to the 3.8 branch.

@pablogsal

pablogsal commented Jun 27, 2020

Copy link
Copy Markdown
Member

@lysnikolaou In general is preferable to wait for the PRs to land before closing the issue, so we don't forget to land them if something goes wrong, as closing the issue removes it from the front page and the main search

@lysnikolaou

lysnikolaou commented Jun 27, 2020

Copy link
Copy Markdown
Member Author

Oh, sorry! I thought it was ok to close the issue before landing the backport PRs, but you're right that it is a bit easier to forget things this way. Thanks for the advise! I'll do that in the future.

miss-islington pushed a commit that referenced this pull request Jun 27, 2020
@lysnikolaou
[3.9] bpo-41132: Use pymalloc allocator in the f-string parser (GH-21173
5193d0a 
) (GH-21183)

(cherry picked from commit 6dcbc24)

Automerge-Triggered-By: @pablogsal
@pablogsal

pablogsal commented Jun 27, 2020

Copy link
Copy Markdown
Member

Oh, sorry!

No worries! Is just that this has happened to us several times so I want to transfer the knowledge acquired from past mistakes 😉

miss-islington pushed a commit that referenced this pull request Jun 27, 2020
@lysnikolaou
[3.8] bpo-41132: Use pymalloc allocator in the f-string parser (GH-21173
749d3bc 
) (GH-21184)

Automerge-Triggered-By: @pablogsal
@ericvsmith

ericvsmith commented Jun 27, 2020

Copy link
Copy Markdown
Member

@lysnikolaou Manual backport party 🎉

Hah!

Thanks for all the work, @lysnikolaou and @pablogsal !

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@lysnikolaou @fasihahmad
bpo-41132: Use pymalloc allocator in the f-string parser (pythonGH-21173
937bb13 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lysnikolaou @miss-islington @pablogsal @bedevere-bot @ericvsmith @the-knights-who-say-ni