Skip to content

[3.7] bpo-41068: Fix read after write in zipfile for non-ASCII files names. (GH-21040)#21049

Closed
miss-islington wants to merge 1 commit into
python:3.7from
miss-islington:backport-36ff513-3.7
Closed

[3.7] bpo-41068: Fix read after write in zipfile for non-ASCII files names. (GH-21040)#21049
miss-islington wants to merge 1 commit into
python:3.7from
miss-islington:backport-36ff513-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jun 22, 2020 •
edited by bedevere-bot
Loading

(cherry picked from commit 36ff513)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

https://bugs.python.org/issue41068

@serhiy-storchaka @miss-islington
bpo-41068: Fix read after write in zipfile for non-ASCII files names. (…
8d597a4 
…pythonGH-21040)

(cherry picked from commit 36ff513)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Jun 22, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2020
Merged
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jun 22, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jun 22, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jun 22, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Jun 22, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented Jun 23, 2020

As announced, with the tagging of 3.7.8rc1, the 3.7 branch is now in security-fix mode. This change doesn't strike me as meeting the criteria for either a security fix or a release-critical fix for 3.7.8 final. I'm reluctant to throw this change in at the last minute but if you can get another core developer to review and approve it, I'll consider it.

@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented Jun 28, 2020

3.7.8 is now released and 3.7 is now in security-fix mode

@ned-deily ned-deily closed this Jun 28, 2020
@miss-islington miss-islington deleted the backport-36ff513-3.7 branch June 28, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

awaiting merge type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @ned-deily @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot