Skip to content

bpo-12800: 'tarfile.StreamError: seeking backwards is not allowed' when extract symlink#20972

Closed
catlee wants to merge 3 commits into
python:masterfrom
catlee:fix-issue-12800
Closed

bpo-12800: 'tarfile.StreamError: seeking backwards is not allowed' when extract symlink#20972
catlee wants to merge 3 commits into
python:masterfrom
catlee:fix-issue-12800

Conversation

@catlee
Copy link
Copy Markdown

@catlee catlee commented Jun 18, 2020 •
edited by bedevere-bot
Loading

This is addressing the review comments in #13217

https://bugs.python.org/issue12800

websurfer5 and others added 3 commits June 18, 2020 18:07
@websurfer5 @catlee
bpo-12800: Extracting a symlink from a tarball using the tarfile
b169b5c 
module in stream mode ('r|') fails with an exception when a file
or symlink of the same name already exists. The fix is to remove
the existing file or symlink before extraction. Tests are included.
@blurb-it @catlee
📜🤖 Added by blurb_it.
bce13d6
@catlee
Fix tests as per review comments
700c3f0
@catlee catlee requested a review from ethanfurman as a code owner June 18, 2020 22:39
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jun 18, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@catlee

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@catlee catlee mentioned this pull request Jun 19, 2020
Closed
@JulienPalard
Copy link
Copy Markdown
Member

JulienPalard commented Jul 9, 2020 •
edited
Loading

I'm not a fan of using open to create a file, what about using pathlib?

Also why tar.extractall(path=support.SAVEDCWD)? It will extract to the cpython root, out of the temporary directory, so it won't get cleaned afterwards.

For readability maybe rename source to regular_file, and link to symlink.

@JulienPalard JulienPalard mentioned this pull request Jul 9, 2020
Merged
@JulienPalard
Copy link
Copy Markdown
Member

JulienPalard commented Jul 9, 2020

Oh, @catlee, took more time to look at it, I started suspecting strange thing while spotting the exact same test already existing in the file. See my comment in bpo.

I opened a much simpler PR #21409 restoring the original test instead of writing new ones.

@taleinat
Copy link
Copy Markdown
Contributor

taleinat commented Sep 19, 2020

Good catch @JulienPalard!

Thanks for the PR, @catlee, but I'm closing this in favor of PR GH-21409.

@taleinat taleinat closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@catlee @the-knights-who-say-ni @JulienPalard @taleinat @bedevere-bot @websurfer5