Skip to content

bpo-32604: Clean up test.support.interpreters. #20926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Jun 17, 2020
Merged

bpo-32604: Clean up test.support.interpreters. #20926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
153222a
Clean up test.test_interpreters.TestSendRecv.
ericsnowcurrently Jun 16, 2020
09d572a
Add TestSendRecv tests for different interpreters.
ericsnowcurrently Jun 16, 2020
5f04304
Clean up interpreters.py a bit.
ericsnowcurrently Jun 16, 2020
4168c22
Clean up test.test_interpreters a bit.
ericsnowcurrently Jun 16, 2020
5f41b02
Fill in some BPO numbers.
ericsnowcurrently Jun 16, 2020
72d4838
Fix whitespace.
ericsnowcurrently Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fill in some BPO numbers.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Jun 16, 2020
commit 5f41b028d3fc63a4b607e7c11a21f48d06799767
3 changes: 3 additions & 0 deletions Lib/test/support/interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def id(self):
def isolated(self):
if self._isolated is None:
# XXX The low-level function has not been added yet.
# See bpo-....
self._isolated = _interpreters.is_isolated(self._id)
return self._isolated

Expand Down Expand Up @@ -180,6 +181,7 @@ def send(self, obj):
"""
_interpreters.channel_send(self._id, obj)
# XXX We are missing a low-level channel_send_wait().
# See bpo-32604 and gh-19829.
# Until that shows up we fake it:
time.sleep(2)

Expand All @@ -191,4 +193,5 @@ def send_nowait(self, obj):
"""
# XXX Note that at the moment channel_send() only ever returns
# None. This should be fixed when channel_send_wait() is added.
# See bpo-32604 and gh-19829.
return _interpreters.channel_send(self._id, obj)
6 changes: 3 additions & 3 deletions Lib/test/test_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,12 @@ def test_id_readonly(self):
with self.assertRaises(AttributeError):
interp.id = 2

@unittest.skip('not ready yet (see BPO-...)')
@unittest.skip('not ready yet (see bpo-32604)')
def test_main_isolated(self):
main = interpreters.get_main()
self.assertFalse(main.isolated)

@unittest.skip('not ready yet (see BPO-...)')
@unittest.skip('not ready yet (see bpo-32604)')
def test_subinterpreter_isolated_default(self):
interp = interpreters.create()
self.assertFalse(interp.isolated)
Expand All @@ -215,7 +215,7 @@ def test_subinterpreter_isolated_explicit(self):
self.assertTrue(interp1.isolated)
self.assertFalse(interp2.isolated)

@unittest.skip('not ready yet (see BPO-...)')
@unittest.skip('not ready yet (see bpo-32604)')
def test_custom_isolated_default(self):
interp = interpreters.Interpreter(1)
self.assertFalse(interp.isolated)
Expand Down