Skip to content

bpo-40956: Use Argument Clinic in sqlite3 module #20826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland wants to merge 9 commits into from
Closed

bpo-40956: Use Argument Clinic in sqlite3 module #20826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5906b3
Convert module level functions except connect
Jun 13, 2020
2557de5
Convert Connection
Jun 13, 2020
6e1a726
Convert Row
Jun 13, 2020
311740f
Convert Cache
Jun 13, 2020
d21accb
Convert PrepareProtocol
Jun 13, 2020
d5baf45
Convert Cursor
Jun 13, 2020
144d84a
Convert sqlite3.connect() and Connection.__init__()
Jun 14, 2020
dab5c43
Add NEWS
Jun 14, 2020
822d50f
Sync clinic with master
Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Sync clinic with master
  • Loading branch information
Erlend E. Aasland committed Sep 8, 2020
commit 822d50fd793df7b72bcf13891d49e66bddc190e5
18 changes: 5 additions & 13 deletions Modules/_sqlite/clinic/connection.c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ PyDoc_STRVAR(pysqlite_connection_set_trace_callback__doc__,
#define PYSQLITE_CONNECTION_SET_TRACE_CALLBACK_METHODDEF \
{"set_trace_callback", (PyCFunction)pysqlite_connection_set_trace_callback, METH_O, pysqlite_connection_set_trace_callback__doc__},

#if defined(HAVE_LOAD_EXTENSION)
#if !defined(SQLITE_OMIT_LOAD_EXTENSION)

PyDoc_STRVAR(pysqlite_connection_enable_load_extension__doc__,
"enable_load_extension($self, enable, /)\n"
Expand Down Expand Up @@ -400,9 +400,9 @@ pysqlite_connection_enable_load_extension(pysqlite_Connection *self, PyObject *a
return return_value;
}

#endif /* defined(HAVE_LOAD_EXTENSION) */
#endif /* !defined(SQLITE_OMIT_LOAD_EXTENSION) */

#if defined(HAVE_LOAD_EXTENSION)
#if !defined(SQLITE_OMIT_LOAD_EXTENSION)

PyDoc_STRVAR(pysqlite_connection_load_extension__doc__,
"load_extension($self, name, /)\n"
Expand Down Expand Up @@ -442,7 +442,7 @@ pysqlite_connection_load_extension(pysqlite_Connection *self, PyObject *arg)
return return_value;
}

#endif /* defined(HAVE_LOAD_EXTENSION) */
#endif /* !defined(SQLITE_OMIT_LOAD_EXTENSION) */

PyDoc_STRVAR(pysqlite_connection_execute__doc__,
"execute($self, sql, /, parameters=<unrepresentable>)\n"
Expand Down Expand Up @@ -575,8 +575,6 @@ pysqlite_connection_iterdump(pysqlite_Connection *self, PyObject *Py_UNUSED(igno
return pysqlite_connection_iterdump_impl(self);
}

#if defined(HAVE_BACKUP_API)

PyDoc_STRVAR(pysqlite_connection_backup__doc__,
"backup($self, /, target=<unrepresentable>, *, pages=-1, progress=None,\n"
" name=\'main\', sleep=0.25)\n"
Expand Down Expand Up @@ -677,8 +675,6 @@ pysqlite_connection_backup(pysqlite_Connection *self, PyObject *const *args, Py_
return return_value;
}

#endif /* defined(HAVE_BACKUP_API) */

PyDoc_STRVAR(pysqlite_connection_create_collation__doc__,
"create_collation($self, name, callback, /)\n"
"--\n"
Expand Down Expand Up @@ -779,8 +775,4 @@ pysqlite_connection_exit(pysqlite_Connection *self, PyObject *const *args, Py_ss
#ifndef PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF
#define PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF
#endif /* !defined(PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF) */

#ifndef PYSQLITE_CONNECTION_BACKUP_METHODDEF
#define PYSQLITE_CONNECTION_BACKUP_METHODDEF
#endif /* !defined(PYSQLITE_CONNECTION_BACKUP_METHODDEF) */
/*[clinic end generated code: output=d1fb1f48710a3cd4 input=a9049054013a1b77]*/
/*[clinic end generated code: output=578e5f247210bbdf input=a9049054013a1b77]*/
10 changes: 1 addition & 9 deletions Modules/_sqlite/clinic/module.c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ pysqlite_complete_statement(PyObject *module, PyObject *arg)
return return_value;
}

#if defined(HAVE_SHARED_CACHE)

PyDoc_STRVAR(pysqlite_enable_shared_cache__doc__,
"enable_shared_cache($module, enable, /)\n"
"--\n"
Expand Down Expand Up @@ -183,8 +181,6 @@ pysqlite_enable_shared_cache(PyObject *module, PyObject *arg)
return return_value;
}

#endif /* defined(HAVE_SHARED_CACHE) */

PyDoc_STRVAR(pysqlite_register_adapter__doc__,
"register_adapter($module, type, caster, /)\n"
"--\n"
Expand Down Expand Up @@ -321,8 +317,4 @@ pysqlite_adapt(PyObject *module, PyObject *const *args, Py_ssize_t nargs)
exit:
return return_value;
}

#ifndef PYSQLITE_ENABLE_SHARED_CACHE_METHODDEF
#define PYSQLITE_ENABLE_SHARED_CACHE_METHODDEF
#endif /* !defined(PYSQLITE_ENABLE_SHARED_CACHE_METHODDEF) */
/*[clinic end generated code: output=5e0bb0b26046264e input=a9049054013a1b77]*/
/*[clinic end generated code: output=79068baf73b272f8 input=a9049054013a1b77]*/