Skip to content

bpo-38605: Make postponed evaluation of annotations default #20434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 18 commits into from
Oct 6, 2020
Merged

bpo-38605: Make postponed evaluation of annotations default #20434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4c5b314
make future annotations default
isidentical May 27, 2020
3402877
Fix test_coroutines
isidentical May 27, 2020
9a131a2
Regenerate bytecode for test_dis
isidentical May 27, 2020
fdcea4d
Regenerate static strings for docxmlrpc and pydoc tests
isidentical May 27, 2020
14e7c2d
Update tests for: syntax, opcodes, posonly, grammar...
isidentical May 27, 2020
f217d48
Refactor inspect tests(+doctests) with string annotations
isidentical May 27, 2020
6209fa0
Add documentation, tests for annotations
isidentical May 27, 2020
bbf01bb
Escape double stringified annotations on typing.ForwardRef
isidentical May 27, 2020
246577d
Fix test_dataclassess
isidentical May 27, 2020
1d77917
Initial attempt for typing fix
isidentical May 29, 2020
6bd5fee
Rename test, apply doc suggestion
isidentical May 29, 2020
1e2c3f8
Adapt code into the latest changes
isidentical Oct 1, 2020
0a04da8
Support double-stringified annotations in dataclasses
isidentical Oct 3, 2020
6d1feb5
Use get_type_hints in inspect.signature
isidentical Oct 4, 2020
86181e4
remove reduntant test
isidentical Oct 4, 2020
4276284
Add what's new entry
isidentical Oct 5, 2020
5ae4bd1
mention about inspect.signature
isidentical Oct 5, 2020
1e73aa7
Tweak what's new words
gvanrossum Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support double-stringified annotations in dataclasses
  • Loading branch information
@isidentical
isidentical committed Oct 3, 2020
commit 0a04da8a9d4bac80e0e912bbf8c62599dc3e65d1
6 changes: 6 additions & 0 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,12 @@ def _is_type(annotation, cls, a_module, a_type, is_type_predicate):
# a eval() penalty for every single field of every dataclass
# that's defined. It was judged not worth it.

# Strip away the extra quotes as a result of double-stringifying when the
# 'annotations' feature became default.
if annotation.startswith(("'", '"')) and annotation.endswith(("'", '"')):
annotation = annotation[1:-1]


Comment thread
isidentical marked this conversation as resolved.
Outdated
match = _MODULE_IDENTIFIER_RE.match(annotation)
if match:
ns = None
Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,6 +2805,13 @@ class C:


class TestStringAnnotations(unittest.TestCase):
def test_double_stringification(self):
@dataclass
class T:
a: "typing.ClassVar[int]"

T()
Comment thread
isidentical marked this conversation as resolved.
Outdated

def test_classvar(self):
# These tests assume that both "import typing" and "from
# typing import *" have been run in this file.
Expand Down