Skip to content

[3.8] bpo-35714: Reject null characters in struct format strings (GH-16928)#20419

Merged
serhiy-storchaka merged 2 commits into
python:3.8from
ZackerySpytz:backport-3f59b55-3.8
May 26, 2020
Merged

[3.8] bpo-35714: Reject null characters in struct format strings (GH-16928)#20419
serhiy-storchaka merged 2 commits into
python:3.8from
ZackerySpytz:backport-3f59b55-3.8

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented May 26, 2020

Copy link
Copy Markdown
Contributor

struct.error is now raised if there is a null character in a struct
format string.
(cherry picked from commit 3f59b55)

https://bugs.python.org/issue35714

…honGH-16928)

struct.error is now raised if there is a null character in a struct
format string.
(cherry picked from commit 3f59b55)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 26, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-20420 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2020
…honGH-16928) (pythonGH-20419)

struct.error is now raised if there is a null character in a struct
format string.
(cherry picked from commit 3f59b55)
(cherry picked from commit 5ff5edf)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5ff5edfef63b3dbc1abb004b3fa4b3db87e79ff9 3.6

miss-islington added a commit that referenced this pull request May 26, 2020
…16928) (GH-20419)

struct.error is now raised if there is a null character in a struct
format string.
(cherry picked from commit 3f59b55)
(cherry picked from commit 5ff5edf)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants