Skip to content

bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows. #20035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 2 commits into from
Closed

bpo-40596: Fix str.isidentifier() for non-canonicalized strings containing non-BMP characters on Windows. #20035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4dfd3
bpo-40596: Fix str.isidentifier() for non-canonicalized strings conta…
serhiy-storchaka May 11, 2020
750d91f
Apply suggestions from code review
serhiy-storchaka May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@serhiy-storchaka @vstinner
serhiy-storchaka and vstinner authored May 12, 2020
commit 750d91fe0de7b72b991ca3c749248d0f82207024
3 changes: 1 addition & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2320,8 +2320,7 @@ valid_identifier(PyObject *s)
return 0;
}
/* Since there is no way to return an error from PyUnicode_IsIdentifier()
we have to call PyUnicode_READY() to ensure that the string object is
in the "canonical" representation. */
we have to call explicitly PyUnicode_READY(). */
if (PyUnicode_READY(s) < 0) {
return 0;
}
Expand Down
3 changes: 0 additions & 3 deletions Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12373,9 +12373,6 @@ static PyObject *
unicode_isidentifier_impl(PyObject *self)
/*[clinic end generated code: output=fe585a9666572905 input=2d807a104f21c0c5]*/
{
/* Since there is no way to return an error from PyUnicode_IsIdentifier()
we have to call PyUnicode_READY() to ensure that the string object is
in the "canonical" representation. */
if (PyUnicode_READY(self) < 0) {
return NULL;
}
Expand Down