Skip to content

bpo-23677: Mention dict and set comprehension in stdtypes #20027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
furkanonder wants to merge 8 commits into from
Closed

bpo-23677: Mention dict and set comprehension in stdtypes #20027

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60b4c94
bpo-23677: Mention dict and set comprehension
furkanonder May 10, 2020
03d76e9
fix typo
furkanonder May 10, 2020
5a3dd75
Update stdtypes.rst
furkanonder May 12, 2020
8a116b5
Update stdtypes.rst
furkanonder May 12, 2020
ae7bdab
Merge branch 'bpo-23677' of github.com:furkanonder/cpython into bpo-2…
furkanonder Dec 13, 2021
2071830
Update set description
furkanonder Dec 13, 2021
e8a83fa
Update Doc/library/stdtypes.rst
rhettinger Jan 2, 2022
e144987
Update the description of the creation of dict
furkanonder Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Doc/library/stdtypes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4106,8 +4106,10 @@ its contents cannot be altered after it is created; it can therefore be used as
a dictionary key or as an element of another set.

Non-empty sets (not frozensets) can be created by placing a comma-separated list
of elements within braces, for example: ``{'jack', 'sjoerd'}``, in addition to the
:class:`set` constructor.
of elements within braces, for example: ``{'jack', 'sjoerd'}``. Sets can
be created by using a set comprehension, for example ``{2 * x for x in iterable}``.
Also, set comprehensions can make both empty and non-empty sets. In addition to
the :class:`set` constructor.
Comment thread
furkanonder marked this conversation as resolved.
Comment on lines +4109 to +4112

@JelleZijlstra JelleZijlstra Apr 14, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of elements within braces, for example: ``{'jack', 'sjoerd'}``. Sets can
be created by using a set comprehension, for example ``{2 * x for x in iterable}``.
Also, set comprehensions can make both empty and non-empty sets. In addition to
the :class:`set` constructor.
of elements within braces, for example ``{'jack', 'sjoerd'}``. Sets can
be created by using a :term:`set comprehension`, for example ``{2 * x for x in iterable}``,
or using the :class:`set` constructor.
  • Remove unnecessary sentence about creating empty sets using a setcomp.
  • Fix incomplete sentence
  • Link to the glossary


The constructors for both classes work the same:

Expand Down Expand Up @@ -4303,7 +4305,9 @@ is usually unwise to use them as dictionary keys.)

Dictionaries can be created by placing a comma-separated list of ``key: value``
pairs within braces, for example: ``{'jack': 4098, 'sjoerd': 4127}`` or ``{4098:
'jack', 4127: 'sjoerd'}``, or by the :class:`dict` constructor.
'jack', 4127: 'sjoerd'}``, by a dict comprehension, for example: ``{x: x**2 for
x in iterable}``. Dictionaries can also be created by the :class:`dict`
constructor, for example: ``dict(jack=4098, sjoerd=4127)``.
Comment on lines +4308 to +4310

@JelleZijlstra JelleZijlstra Apr 14, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'jack', 4127: 'sjoerd'}``, by a dict comprehension, for example: ``{x: x**2 for
x in iterable}``. Dictionaries can also be created by the :class:`dict`
constructor, for example: ``dict(jack=4098, sjoerd=4127)``.
'jack', 4127: 'sjoerd'}``, or by a :term:`dictionary comprehension`, for example: ``{x: x**2 for
x in iterable}``. Dictionaries can also be created by the :class:`dict`
constructor, for example: ``dict(jack=4098, sjoerd=4127)``.

Link the glossary term


.. class:: dict(**kwarg)
dict(mapping, **kwarg)
Expand Down