Skip to content

[doc] Remove references to obsolete BuildApplet on macOS.#20023

Merged
ned-deily merged 2 commits into
python:masterfrom
andresdelfino:fix_macpython_version
May 21, 2020
Merged

[doc] Remove references to obsolete BuildApplet on macOS.#20023
ned-deily merged 2 commits into
python:masterfrom
andresdelfino:fix_macpython_version

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented May 10, 2020

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 10, 2020
@tirkarthi
Copy link
Copy Markdown
Member

tirkarthi commented May 19, 2020

cc: @ned-deily

@ned-deily ned-deily self-assigned this May 19, 2020
ned-deily
ned-deily requested changes May 21, 2020
View reviewed changes
Comment thread Doc/using/mac.rst
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 21, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino
Copy link
Copy Markdown
Contributor Author

andresdelfino commented May 21, 2020

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 21, 2020

Nobody expects the Spanish Inquisition!

@ned-deily: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ned-deily May 21, 2020 11:58
ned-deily
ned-deily approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and catching the other reference.

@ned-deily ned-deily changed the title [doc] Update MacPython version [doc] Remove references to obsolete BuildApplet on macOS. May 21, 2020
@ned-deily ned-deily merged commit 7864f11 into python:master May 21, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 21, 2020

Thanks @andresdelfino for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@andresdelfino @miss-islington
[doc] Remove references to obsolete BuildApplet on macOS. (pythonGH-2…
eaee57e 
…0023)

(cherry picked from commit 7864f11)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 21, 2020

GH-20304 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@andresdelfino @miss-islington
[doc] Remove references to obsolete BuildApplet on macOS. (pythonGH-2…
f51a33f 
…0023)

(cherry picked from commit 7864f11)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2020
@andresdelfino @miss-islington
[doc] Remove references to obsolete BuildApplet on macOS. (pythonGH-2…
0375e94 
…0023)

(cherry picked from commit 7864f11)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
ned-deily pushed a commit that referenced this pull request May 21, 2020
@miss-islington @andresdelfino
[doc] Remove references to obsolete BuildApplet on macOS. (GH-20023) (G…
b4d08f1 
…H-20304)

(cherry picked from commit 7864f11)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request May 21, 2020
@miss-islington @andresdelfino
[doc] Remove references to obsolete BuildApplet on macOS. (GH-20023)
822efa5 
(cherry picked from commit 7864f11)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request May 21, 2020
@miss-islington
[3.7] [doc] Remove references to obsolete BuildApplet on macOS (GH-20023
3613bf0 
) (GH-20306)

(cherry picked from commit 7864f11)


Co-authored-by: Andre Delfino <adelfino@gmail.com>

Automerge-Triggered-By: @ned-deily
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@andresdelfino @arturoescaip
[doc] Remove references to obsolete BuildApplet on macOS. (pythonGH-2…
2d0359e 
…0023)
@andresdelfino andresdelfino deleted the fix_macpython_version branch July 13, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

@ned-deily ned-deily

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andresdelfino @tirkarthi @bedevere-bot @miss-islington @ned-deily @the-knights-who-say-ni