Skip to content

bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError() #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scoder merged 2 commits into from
May 11, 2020
+3 −1
Merged

bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError() #20018

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7271ad8
bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError()…
scoder May 9, 2020
c7e07c3
Apply suggestions from code review
scoder May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError()… 
… by calling

_PyDict_GetItem_KnownHash() instead of the more generic PyDict_GetItemWithError(),
since we already know the hash of interned strings.
  • Loading branch information
@scoder
scoder committed May 9, 2020
commit 7271ad8524e5adda7422f3ed69a91bd53badac39
5 changes: 4 additions & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,11 +1488,14 @@ PyDict_GetItemWithError(PyObject *op, PyObject *key)
PyObject *
_PyDict_GetItemIdWithError(PyObject *dp, struct _Py_Identifier *key)
{
Py_hash_t hash;
Comment thread
scoder marked this conversation as resolved.
Outdated
PyObject *kv;
kv = _PyUnicode_FromId(key); /* borrowed */
if (kv == NULL)
return NULL;
return PyDict_GetItemWithError(dp, kv);
hash = ((PyASCIIObject *) kv)->hash;
Comment thread
scoder marked this conversation as resolved.
Outdated
assert (hash != -1); /* interned strings have their hash value initialised */
return _PyDict_GetItem_KnownHash(dp, kv, hash);
}

PyObject *
Expand Down