Skip to content

bpo-40334: Avoid collisions between parser variables and grammar variables #19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
May 10, 2020
Merged

bpo-40334: Avoid collisions between parser variables and grammar variables #19987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8855028
bpo-40334: Avoid collisions between parser variables and grammar vari…
pablogsal May 8, 2020
9a5559d
Address feedback
pablogsal May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-40334: Avoid collisions between parser variables and grammar vari… 
…ables
  • Loading branch information
@pablogsal
pablogsal committed May 10, 2020
commit 885502807106ba34312f9b30a328fe852338bacd
27 changes: 27 additions & 0 deletions Lib/test/test_peg_generator/test_pegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,33 @@ def test_missing_start(self) -> None:
with self.assertRaises(GrammarError):
parser_class = make_parser(grammar)

def test_invalid_rule_name(self) -> None:
grammar = """
start: a b
_a: 'a'
b: 'b'
"""
with self.assertRaises(GrammarError):
Comment thread
pablogsal marked this conversation as resolved.
Outdated
parser_class = make_parser(grammar)

def test_invalid_variable_name(self) -> None:
grammar = """
start: a b
a: _x='a'
b: 'b'
"""
with self.assertRaises(GrammarError):
parser_class = make_parser(grammar)

def test_invalid_variable_name_in_temporal_rule(self) -> None:
grammar = """
start: a b
a: (_x='a' | 'b') | 'c'
b: 'b'
"""
with self.assertRaises(GrammarError):
parser_class = make_parser(grammar)


class TestGrammarVisitor:
class Visitor(GrammarVisitor):
Expand Down
Loading