Skip to content

bpo-1635741: Port errno module to multiphase initialization #19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 5 commits into from
May 7, 2020
Merged

bpo-1635741: Port errno module to multiphase initialization #19923

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f878c7
bpo-1635741: Port errno module to multiphase initialization
corona10 May 5, 2020
649743b
bpo-1635741: Apply code review
corona10 May 5, 2020
015b280
bot-1635741: Apply code review
corona10 May 6, 2020
2b241ca
bpo-1635741: Update
corona10 May 6, 2020
9c94c4f
Update Modules/errnomodule.c
corona10 May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Modules/errnomodule.c 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@corona10 @vstinner
corona10 and vstinner authored May 6, 2020
commit 9c94c4f249b660ec798b12b35eb102088751528c
6 changes: 5 additions & 1 deletion Modules/errnomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ errno_exec(PyObject *module)
{
PyObject *module_dict = PyModule_GetDict(module);
PyObject *error_dict = PyDict_New();
if (!module_dict || !error_dict || PyDict_SetItemString(module_dict, "errorcode", error_dict) < 0) {
if (!module_dict || !error_dict) {
return -1;
}
if (PyDict_SetItemString(module_dict, "errorcode", error_dict) < 0) {
Py_DECREF(error_dict);
return -1;
}

Expand Down