Skip to content

bpo-40480 "fnmatch" exponential execution time #19908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-one merged 5 commits into from
May 6, 2020
Merged

bpo-40480 "fnmatch" exponential execution time #19908

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7c0e5e
bpo-40480 "fnmatch" exponential execution time
tim-one May 4, 2020
a158f62
trivial edits
tim-one May 4, 2020
1d61b7f
📜🤖 Added by blurb_it.
blurb-it[bot] May 4, 2020
fbb7048
Moved the block of new translate() tests into the right
tim-one May 4, 2020
86d1d0d
Removed useless code from an earlier version.
tim-one May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved the block of new translate() tests into the right 
test function.
  • Loading branch information
@tim-one
tim-one committed May 4, 2020
commit fbb7048393041e4a691cb87572212ea8257dd745
20 changes: 10 additions & 10 deletions Lib/test/test_fnmatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,6 @@ def test_fnmatch(self):
check('foo\nbar\n', 'foo*')
check('\nfoo', 'foo*', False)
check('\n', '*')
# from the docs
self.assertEqual(translate('*.txt'), r'(?s:.*\.txt)\Z')
# squash consecutive stars
self.assertEqual(translate('*********'), r'(?s:.*)\Z')
self.assertEqual(translate('A*********'), r'(?s:A.*)\Z')
self.assertEqual(translate('*********A'), r'(?s:.*A)\Z')
self.assertEqual(translate('A*********?[?]?'), r'(?s:A.*.[?].)\Z')
# fancy translation to prevent exponential-time match failure
self.assertEqual(translate('**a*a****a'),
r'(?s:(?=(?P<g1>.*?a))(?P=g1)(?=(?P<g2>.*?a))(?P=g2).*a)\Z')

def test_slow_fnmatch(self):
check = self.check_match
Expand Down Expand Up @@ -124,6 +114,16 @@ def test_translate(self):
self.assertEqual(translate('[!x]'), r'(?s:[^x])\Z')
self.assertEqual(translate('[^x]'), r'(?s:[\^x])\Z')
self.assertEqual(translate('[x'), r'(?s:\[x)\Z')
# from the docs
self.assertEqual(translate('*.txt'), r'(?s:.*\.txt)\Z')
# squash consecutive stars
self.assertEqual(translate('*********'), r'(?s:.*)\Z')
self.assertEqual(translate('A*********'), r'(?s:A.*)\Z')
self.assertEqual(translate('*********A'), r'(?s:.*A)\Z')
self.assertEqual(translate('A*********?[?]?'), r'(?s:A.*.[?].)\Z')
# fancy translation to prevent exponential-time match failure
self.assertEqual(translate('**a*a****a'),
r'(?s:(?=(?P<g1>.*?a))(?P=g1)(?=(?P<g2>.*?a))(?P=g2).*a)\Z')


class FilterTestCase(unittest.TestCase):
Expand Down