Skip to content

bpo-40458: Increase reserved stack space to prevent overflow crash on Windows #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 5 commits into from
May 5, 2020
Merged

bpo-40458: Increase reserved stack space to prevent overflow crash on Windows #19845

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbd571e
bpo-40458: Increase reserved stack space to prevent overflow crash on…
zooba May 1, 2020
a7a12ce
Also update pythonw
zooba May 1, 2020
6588ebc
Avoid setting exception if overflow occurs outside of a Python thread
zooba May 1, 2020
f06a322
Update test
zooba May 1, 2020
6c53dd4
Revert improved diagnostics
zooba May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid setting exception if overflow occurs outside of a Python thread
  • Loading branch information
@zooba
zooba committed May 1, 2020
commit 6588ebc4509519b178a0b3c43004d73fd9f99bab
3 changes: 2 additions & 1 deletion Modules/faulthandler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ faulthandler_exc_handler(struct _EXCEPTION_POINTERS *exc_info)
case EXCEPTION_IN_PAGE_ERROR: PUTS(fd, "page error"); break;
case EXCEPTION_STACK_OVERFLOW:
PUTS(fd, "stack overflow");
tstate = get_thread_state();
/* call UncheckedGet directly to avoid setting exceptions */
tstate = _PyThreadState_UncheckedGet();
Comment thread
zooba marked this conversation as resolved.
Outdated
if (tstate != NULL) {
PUTS(fd, " (recursion depth=");
_Py_DumpDecimal(fd, tstate->recursion_depth);
Expand Down