Skip to content

bpo-32604: Add support for a "default" arg in channel_recv(). #19770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 3 commits into from
Apr 28, 2020
Merged

bpo-32604: Add support for a "default" arg in channel_recv(). #19770

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5edb12
Add support for a default arg in channel_recv().
ericsnowcurrently Apr 28, 2020
2183afc
Do not exit _channel_recv() without freeing the cross-interpreter data.
ericsnowcurrently Apr 28, 2020
4c2c7cc
Fix a typo in a docstring.
ericsnowcurrently Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not exit _channel_recv() without freeing the cross-interpreter data.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Apr 28, 2020
commit 2183afccb342cfaba531baaa1c32b79a004f3495
4 changes: 2 additions & 2 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,11 +1355,11 @@ _channel_recv(_channels *channels, int64_t id)

// Convert the data back to an object.
PyObject *obj = _PyCrossInterpreterData_NewObject(data);
_PyCrossInterpreterData_Release(data);
PyMem_Free(data);
if (obj == NULL) {
return NULL;
}
_PyCrossInterpreterData_Release(data);
PyMem_Free(data);

return obj;
}
Expand Down