Skip to content

bpo-23082: Better error message for PurePath.relative_to() from pathlib #19611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 3 commits into from
May 25, 2020
Merged

bpo-23082: Better error message for PurePath.relative_to() from pathlib #19611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b979a2f
Better error for PurePath.relative_to() from pathlib
Apr 19, 2020
3c05582
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 20, 2020
e7f0ab1
fixed whitespace issues
Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Better error for PurePath.relative_to() from pathlib 
Changed the error message to be more informative and updated the docs accordingly.
  • Loading branch information
Sadhana Srinivasan authored and Sadhana Srinivasan committed Apr 19, 2020
commit b979a2f1133599d418cd8e546c7a84f11ccbd8bc
5 changes: 4 additions & 1 deletion Doc/library/pathlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,10 @@ Pure paths provide the following methods and properties:
File "<stdin>", line 1, in <module>
File "pathlib.py", line 694, in relative_to
.format(str(self), str(formatted)))
ValueError: '/etc/passwd' does not start with '/usr'
ValueError: '/etc/passwd' is not in the subpath of '/usr' OR one path is relative and the other absolute.


NOTE: This function is part of :class:`PurePath` and works with strings. It does not check or access the underlying file structure.


.. method:: PurePath.with_name(name)
Expand Down
3 changes: 2 additions & 1 deletion Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,8 @@ def relative_to(self, *other):
cf = self._flavour.casefold_parts
if (root or drv) if n == 0 else cf(abs_parts[:n]) != cf(to_abs_parts):
formatted = self._format_parsed_parts(to_drv, to_root, to_parts)
raise ValueError("{!r} does not start with {!r}"
raise ValueError("{!r} is not in the subpath of {!r}"
" OR one path is relative and the other is absolute."
Comment thread
zooba marked this conversation as resolved.
.format(str(self), str(formatted)))
return self._from_parsed_parts('', root if n == 1 else '',
abs_parts[n:])
Expand Down