Skip to content

bpo-40302: Optimize UTF-32 encoder SWAB4() #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Apr 17, 2020
+1 −1
Merged

bpo-40302: Optimize UTF-32 encoder SWAB4() #19572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-40302: Optimize UTF-32 encoder SWAB4() 
Use a | b instead of a + b in  UCS-2 implementation of SWAB4().
  • Loading branch information
@vstinner
vstinner committed Apr 17, 2020
commit 9388df97601d4906b0217eb9276f8a8730fd80bd
2 changes: 1 addition & 1 deletion Objects/stringlib/codecs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ STRINGLIB(SWAB4)(STRINGLIB_CHAR ch)
return (word << 24);
#elif STRINGLIB_SIZEOF_CHAR == 2
/* high bytes are zero */
return ((word & 0x00FFu) << 24) + ((word & 0xFF00u) << 8);
return ((word & 0x00FFu) << 24) | ((word & 0xFF00u) << 8);
#else
return _Py_bswap32(word);
#endif
Expand Down