bpo-32494: Add gdbm.count()#19569
Conversation
gdbm_count() was added in GDBM 1.11.
pitrou
left a comment
There was a problem hiding this comment.
Thank you. This looks mostly good, just one comment.
| { | ||
| gdbm_count_t count; | ||
| check_dbmobject_open(self); | ||
| if (gdbm_count(self->di_dbm, &count) == -1) { |
There was a problem hiding this comment.
Need to set errno = 0 before this.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Can we just replace the logic of dbm_length to use gdbm_count when the version is available?
Line 98 in 1b55b65
if possible, we don't have to export a new method.
|
Superseded by PR #19814. Closing. |
gdbm_count() was added in GDBM 1.11.
https://bugs.python.org/issue32494