Skip to content

[3.8] Document missing methods of ssl.SSLObject (GH-19400)#19407

Merged
miss-islington merged 3 commits into
python:3.8from
miss-islington:backport-74e1b6b-3.8
Jun 29, 2020
Merged

[3.8] Document missing methods of ssl.SSLObject (GH-19400)#19407
miss-islington merged 3 commits into
python:3.8from
miss-islington:backport-74e1b6b-3.8

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Apr 7, 2020

Co-authored-by: Rémi Lapeyre remi.lapeyre@lenstra.fr
(cherry picked from commit 74e1b6b)

Co-authored-by: Rémi Lapeyre remi.lapeyre@henki.fr

@miss-islington
Document missing methods of ssl.SSLObject (pythonGH-19400)
d1d4775 
Co-authored-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>
(cherry picked from commit 74e1b6b)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@miss-islington miss-islington requested a review from tiran as a code owner April 7, 2020 07:39
@bedevere-bot bedevere-bot mentioned this pull request Apr 7, 2020
Merged
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Apr 7, 2020

@remilapeyre and @tiran: Status check is done, and it's a failure ❌ .

@csabella
Copy link
Copy Markdown
Contributor

csabella commented May 27, 2020

@tiran, @remilapeyre, is this just waiting for the approval to finish the backport? Thanks!

@remilapeyre
Copy link
Copy Markdown

remilapeyre commented Jun 15, 2020

@tiran I think this PR is ready to be merged :)

@tiran
Copy link
Copy Markdown
Member

tiran commented Jun 16, 2020

CI is failing :(

@tiran tiran self-assigned this Jun 16, 2020
@remilapeyre
Copy link
Copy Markdown

remilapeyre commented Jun 16, 2020 •
edited
Loading

It looks like it's failing for an unrelated change:

/Users/remi/src/cpython/Doc/c-api/buffer.rst:92:Error in declarator or parameters
Invalid C declaration: Expected identifier in nested name. [error at 5]
  void \*buf
  -----^
make[1]: *** [build] Error 2
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.

It has since been fixed and merging origin/3.8 in this branch fixes the issue but I don't think I can push on this PR to fix it thought.

Edit: yes, it was fixed in 37a257c

@miss-islington miss-islington merged commit 12bb0b6 into python:3.8 Jun 29, 2020
@miss-islington miss-islington deleted the backport-74e1b6b-3.8 branch June 29, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

+1 more reviewer

@remilapeyre remilapeyre remilapeyre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tiran tiran

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@miss-islington @csabella @remilapeyre @tiran @ned-deily @the-knights-who-say-ni @bedevere-bot